Skip to content

sqlite: refactor error helpers and user function pointers#62794

Open
thisalihassan wants to merge 1 commit intonodejs:mainfrom
thisalihassan:sqlite-refactor-error-and-udf-ptrs
Open

sqlite: refactor error helpers and user function pointers#62794
thisalihassan wants to merge 1 commit intonodejs:mainfrom
thisalihassan:sqlite-refactor-error-and-udf-ptrs

Conversation

@thisalihassan
Copy link
Copy Markdown
Contributor

@thisalihassan thisalihassan commented Apr 17, 2026

Two small independent refactors.

  1. Consolidate CreateSQLiteError overloads
  2. BaseObjectWeakPtr for user functions (style consistency)

@thisalihassan
sqlite: refactor error helpers and user function pointers
3162244 
Signed-off-by: Ali Hassan <ali-hassan27@outlook.com>
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Apr 17, 2026

Review requested:

  • @nodejs/sqlite

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. labels Apr 17, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 17, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 88.88889% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.68%. Comparing base (4e612c0) to head (3162244).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/node_sqlite.cc 88.88% 1 Missing and 3 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #62794      +/-   ##
==========================================
- Coverage   89.69%   89.68%   -0.02%     
==========================================
  Files         706      706              
  Lines      218247   218252       +5     
  Branches    41777    41782       +5     
==========================================
- Hits       195760   195730      -30     
- Misses      14401    14438      +37     
+ Partials     8086     8084       -2
Files with missing lines Coverage Δ
src/node_sqlite.h 80.64% <ø> (ø)
src/node_sqlite.cc 80.78% <88.88%> (+0.05%) ⬆️

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@thisalihassan
Copy link
Copy Markdown
Contributor Author

thisalihassan commented Apr 21, 2026

@nodejs/sqlite @geeksilva97 can I get a review please?

@geeksilva97
Copy link
Copy Markdown
Contributor

geeksilva97 commented Apr 21, 2026

Sure. Will take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thisalihassan @nodejs-github-bot @geeksilva97